fix: Remove support for MSC3575 #4531
Draft
+144
−1,242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
fix-remove-msc3575
branch
from
013c7d7 to
c8a3d71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4531 +/- ##
==========================================
- Coverage 85.41% 85.38% -0.04%
==========================================
Files 285 285
Lines 32215 32100 -115
==========================================
- Hits 27518 27410 -108
+ Misses 4697 4690 -7 ☔ View full report in Codecov by Sentry. |
bnjbvr
requested changes
Jan 14, 2025
| } | ||
|
|
||
| pub use msc4186::*; | ||
| pub use ruma::api::client::sync::sync_events::v5::*; |
There was a problem hiding this comment.
Can we get rid of this file now, and just use use with the ruma full path?
There was a problem hiding this comment.
I've removed this file, but ruma::api::client::sync::sync_events::v5 is re-exported as http inside matrix_sdk_base::sliding_sync. I think it is still comfortable to use matrix_sdk_base::sliding_sync::http to get all the HTTP types for sliding sync without having to look for inside Ruma. It's just a module alias. What do you think?
|
Yup, sure, ruma update has been extracted in #4532. |
Hywan
force-pushed
the
fix-remove-msc3575
branch
from
c8a3d71 to
4453a79
Compare
This patch inlines `sliding_sync::http` inside `sliding_sync`. Then, the `sliding_sync/mod.rs` file is renamed to `sliding_sync.rs`.
Hywan
force-pushed
the
fix-remove-msc3575
branch
from
4453a79 to
04ee9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC3575 is the “first” and “old” version of sliding sync, implemented by the sliding sync proxy and probably other homeservers. MSC4186 is the “next” and “new” version of sliding sync, being implemented inside Synapse and probably other homeservers.
The Matrix Rust SDK was supporting both versions, aiming at giving time to homeservers to transition from the experimental MSC3575 to the stable, production ready MSC4186.
It is time to say good bye to MSC3575.
This is what the first patch does.This patch also needs to update ruma (to include ruma/ruma#1995). Updating ruma involves a bit of breaking changes, it's addressed in a standalone second patch.