feat(sdk): Allow to set and check whether an image is animated #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4503 +/- ##
==========================================
- Coverage 85.37% 85.36% -0.01%
==========================================
Files 284 284
Lines 31885 31886 +1
==========================================
- Hits 27222 27221 -1
- Misses 4663 4665 +2 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Jan 10, 2025
crates/matrix-sdk/CHANGELOG.md
Outdated
|
|
||
| - Allow to set and check whether an image is animated via its `ImageInfo`. | ||
| - Implement `Default` for `BaseImageInfo`, `BaseVideoIndo`, `BaseAudioInfo` and | ||
| `BaseFileInfo`. |
There was a problem hiding this comment.
Ah, I spoke too soon. Could you please link to the PR here?
Using MSC4230. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
image-is-animated
branch
from
c4da95d to
8e15b94
Compare
Since all of their fields are optional, it simplifies their construction. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
image-is-animated
branch
from
8e15b94 to
ece3614
Compare
|
Fixed a typo too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using MSC4230.
While I was in the area I added a second commit to implement
Defaultfor theBase*Infotypes since they only have optional fields and it is easier to construct them that way when we don't want to set all fields.This can be reviewed commit by commit.