chore(event cache): add more logs here and there #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_locked` and replace it with an inlined call to `append_events_locked_impl`, that's then renamed `append_events_locked`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4489 +/- ##
==========================================
- Coverage 85.11% 85.10% -0.02%
==========================================
Files 283 283
Lines 31790 31788 -2
==========================================
- Hits 27059 27052 -7
- Misses 4731 4736 +5 ☔ View full report in Codecov by Sentry. |
bnjbvr
requested review from
a team and
poljar
and removed request for
Hywan and
a team
poljar
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to have some logs when background tasks are shutting down, and also about other kinds of changes related to the event cache.