Introduce simplified sync locks that panic when poisoned

[poljar]

This should help us to enable the unwrap_used clippy lint in the future.

Should be reviewed commit by commit, we first introduce the lock wrappers and then we start using them.

No functional changes.

[jmartinesp]

Thanks, LGTM! I guess we'll be migrating the existing lock().unwrap() and RwLock usages little by little before enabling the clippy check?

[poljar]

Thanks, LGTM! I guess we'll be migrating the existing lock().unwrap() and RwLock usages little by little before enabling the clippy check?

Yes. There are also a bunch of questionable unwraps that are not caused by the locks.

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (dc2775e) to head (6f6629b).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/matrix-sdk-common/src/locks.rs	75.00%	4 Missing ⚠️
...trix-sdk-crypto/src/olm/group_sessions/outbound.rs	93.33%	2 Missing ⚠️
...c/session_manager/group_sessions/share_strategy.rs	50.00%	1 Missing ⚠️
crates/matrix-sdk-crypto/src/store/memorystore.rs	96.42%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4486      +/-   ##
==========================================
- Coverage   85.11%   85.09%   -0.03%     
==========================================
  Files         283      284       +1     
  Lines       31790    31804      +14     
==========================================
+ Hits        27059    27063       +4     
- Misses       4731     4741      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.