refactor(sdk): Rename RoomEvents::filter_duplicated_events
#4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames `RoomEvents::filter_duplicated_events` to `collect_valid_and_duplicated_events` as I believe it improves the understanding of the code. The variables named `unique_events` are renamed `events` as all (valid) events are returned, not only the unique ones.
Hywan
changed the title
RoomEvents::filter_duplicated_events.RoomEvents::filter_duplicated_events
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4481 +/- ##
==========================================
- Coverage 85.12% 85.10% -0.03%
==========================================
Files 283 283
Lines 31768 31768
==========================================
- Hits 27043 27036 -7
- Misses 4725 4732 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames
RoomEvents::filter_duplicated_eventstocollect_valid_and_duplicated_eventsas I believe it improves the understanding of the code. The variables namedunique_eventsare renamedeventsas all (valid) events are returned, not only the unique ones.RoomEventCacheUpdate::AddTimelineItems#4462