Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename TimelineMetadata::all_events to all_remote_events #4366

Merged

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Dec 2, 2024

This patch renames the all_events field to all_remote_events in TimelineMetada for the sake of clarity.


@Hywan Hywan marked this pull request as ready for review December 2, 2024 14:57
@Hywan Hywan requested a review from a team as a code owner December 2, 2024 14:57
@Hywan Hywan requested review from stefanceriu and bnjbvr and removed request for a team and stefanceriu December 2, 2024 14:57
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, feel free to rename add_or_update_event to add_or_update_remote_event too if you'd like (and don't think the name's too long 🙃)

Hywan added 2 commits December 2, 2024 16:03
This patch renames the `all_events` field to `all_remote_events` in
`TimelineMetada` for the sake of clarity.
@Hywan Hywan force-pushed the refactor-ui-timeline-metadata-all-events branch from d703a55 to d1f7e5c Compare December 2, 2024 15:03
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (ad3d1fb) to head (d1f7e5c).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...tes/matrix-sdk-ui/src/timeline/controller/state.rs 78.57% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4366      +/-   ##
==========================================
- Coverage   85.09%   85.09%   -0.01%     
==========================================
  Files         280      280              
  Lines       30547    30558      +11     
==========================================
+ Hits        25995    26003       +8     
- Misses       4552     4555       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan merged commit 80a48f5 into matrix-org:main Dec 2, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants