-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event cache): reload a linked chunk from a store #4362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
) -> Result<Option<LinkedChunk<DEFAULT_CHUNK_CAPACITY, Event, Gap>>, Self::Error> { | ||
// TODO(hywan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job hywan.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4362 +/- ##
==========================================
+ Coverage 85.10% 85.13% +0.02%
==========================================
Files 280 280
Lines 30535 30654 +119
==========================================
+ Hits 25988 26098 +110
- Misses 4547 4556 +9 ☔ View full report in Codecov by Sentry. |
@Hywan FWIW, I've added a small fix in the last commit (with a regression test). If we added an empty items chunk (which is totally fine, by contract), it would incorrectly lead to an invalid data error. Instead, when we find a chunk with no rows, we have to assume it's an empty events chunk. That's the change happening in the last commit. |
All good to me, thanks for the bug fix! |
This implements the following:
Part of #3280