Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-algorithms) Add missing argument to handle_supported_key_request #4157

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

andybalaam
Copy link
Member

This fixes the build

Before this change:

$ cargo check --features=experimental-algorithms
error[E0061]: this method takes 4 arguments but 3 arguments were supplied
   --> crates/matrix-sdk-crypto/src/gossiping/machine.rs:513:30
    |
513 |                         self.handle_supported_key_request(event, &i.room_id, &i.session_id).await
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ----- argument #1 of type `&StoreCache` is missing

@andybalaam andybalaam requested review from a team as code owners October 21, 2024 15:42
@andybalaam andybalaam requested review from poljar and BillCarsonFr and removed request for a team October 21, 2024 15:42
@andybalaam andybalaam enabled auto-merge (rebase) October 21, 2024 15:54
@andybalaam andybalaam merged commit 2df359d into main Oct 21, 2024
39 checks passed
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (951a435) to head (007803a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4157      +/-   ##
==========================================
+ Coverage   84.84%   84.87%   +0.02%     
==========================================
  Files         269      269              
  Lines       28799    28799              
==========================================
+ Hits        24434    24442       +8     
+ Misses       4365     4357       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam deleted the andybalaam/fix-experimental-build branch October 21, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants