Process name changes that come back on the sync api

[zzorba]

In debugging code, we found that the 'name' that comes back on Room responses in sliding sync was seemingly not being processed. This caused name changes to not be reflected in the client.

• Public API changes documented in changelogs (optional)

Signed-off-by: Daniel Salinas

[bnjbvr]

Thanks for the PR, but we've namely deviated from this behavior (that we implemented in the past), because this doesn't work for unnamed DM rooms, where the server would compute a room name, based on the room members ("A and B and C"), which means the server-computed name is always in English, and doesn't fare well with i10n. Accepting this PR would be a regression in terms of that behavior; I suppose you're opening this because you ran into #4051 maybe?

[zzorba]

Yes, we were seeing newly created rooms not receive their name, as well as any room whose name is changed after the initial sync not being updated.

Wouldn't it be possible to change the logic for updating the room name to consider if it is_direct and ignore the stored name in that case in favor of the dynamic localized one? Or store two cached names (server state and local based on heroes) and then prefer the one that applies when accessed?

It seems like the root of the problem here is that it is deciding which name to use during the stream processing (when state might be incomplete), rather than at display time (eventually complete).

[zzorba]

Turned out this was an omission of the sliding-sync proxy go system, exposed by the recent removal of processing timeline events. Closing.