Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ffi): remove two fields in EventTimelineItem #4110

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Oct 10, 2024

  • is_local is the opposite of is_remote. I hope all foreign languages have a ! operator 🤡
  • the two lazy providers can be unified into a single one, avoiding a bit of boilerplate.

Split from #4100.

@bnjbvr bnjbvr requested a review from a team as a code owner October 10, 2024 13:22
@bnjbvr bnjbvr requested review from jmartinesp and removed request for a team October 10, 2024 13:22
@jmartinesp
Copy link
Contributor

is_local is the opposite of is_remote. I hope all foreign languages have a ! operator 🤡

This will do!

val isLocal: Boolean = is_remote.toInt() - 1 == 0

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (85682ac) to head (b07a634).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
- Coverage   84.71%   84.69%   -0.03%     
==========================================
  Files         269      269              
  Lines       28816    28816              
==========================================
- Hits        24411    24405       -6     
- Misses       4405     4411       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I liked the previous *Provider way of splitting responsibilities better, but we'll probably add wrappers for them once they're in Kotlin/Swift anyway, so we can split them there if we want to, so it's no big deal.

@bnjbvr bnjbvr merged commit 3291940 into main Oct 10, 2024
41 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/thinner-event-timeline-item-ffi branch October 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants