Fix splitbrain between .js being ESM & CJS inconsistently

[t3chguy]

Fixes #188

no actual changes to the js/cjs/mjs files barring some ts annotations

Switches the package type to ESM as that is what wasm-pack is outputting
Convinces the wasm bindgen test to use an ESM runner
Uses explicit extensions on the CJS entrypoints

[richvdh]

would it be better to stop using .js altogether, and just call everything .mjs / .cjs, to avoid this sort of confusion?

[t3chguy]

That would also be possible but I somehow hate the idea of having to rename the output files of wasm-pack s/js/mjs - "type": "module" is also a good thing going forward. I can imagine also imagine issues going forward if the tests/entrypoints were ts-ified and needing mts/cts and the issues typescript has around those

Edit: ended up being explicit on the checked in files, still added "type": "module" for wasm-pack generated files and for ts downstream to be happier

[andybalaam]

@richvdh I assigned this to you since you seem to understand it more than me. Feel free to assign another one to me :-)

[richvdh]

no actual changes to the js/cjs/mjs files

This doesn't seem quite right? Could you give the description of the PR an update, please, to give an overview of the approach? (Looks like we're now standardising on .js meaning ESM, and .cjs meaning CommonJS?)

Also, please can you add an entry to the changelog?

[t3chguy]

This doesn't seem quite right? Could you give the description of the PR an update, please, to give an overview of the approach? (Looks like we're now standardising on .js meaning ESM, and .cjs meaning CommonJS?)

Have updated the description

Also, please can you add an entry to the changelog?

Could you please point me to any guidance on doing so? Not seeing anything in the contributing doc

[richvdh]

Also, please can you add an entry to the changelog?
Could you please point me to any guidance on doing so? Not seeing anything in the contributing doc

https://github.com/matrix-org/matrix-rust-sdk/blob/main/CONTRIBUTING.md#writing-changelog-entries is the most relevant guide.

TL;DR though: if you could just add an entry under the "UNRELEASED" heading, following the same style as previous entries, that would be be great.

[richvdh]

LGTM. Thank you.