Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support UI for MSC2762: Widgets reading events from rooms #5960

Merged
merged 4 commits into from
May 17, 2021
Merged

Support UI for MSC2762: Widgets reading events from rooms #5960

merged 4 commits into from
May 17, 2021

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented May 4, 2021 •
edited
Loading

MSC: matrix-org/matrix-spec-proposals#2876 matrix-org/matrix-spec-proposals#2762
Fixes element-hq/element-web#15747

Requires matrix-org/matrix-widget-api#34

Requires matrix-org/matrix-widget-api#37

A release will be cut after review.

Screenshots of a widget requesting data up to a limit:
image

Capabilities proof:
image

@turt2live
Copy link
Member Author

Some test failures are expected while the CI doesn't match up to the widget-api branch.

@turt2live turt2live requested a review from a team May 4, 2021 03:55
jryans
jryans suggested changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "see" for both receive and read seems like it will be misleading, at least for technical users who have any idea what's going on here.

src/widgets/CapabilityText.tsx Outdated Show resolved Hide resolved
jryans
jryans approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you seek a Design opinion on the text, then this looks good to me otherwise.

@turt2live
Copy link
Member Author

Thought-provoking questions have been raised

@turt2live turt2live changed the title Support UI for MSC2876: Widgets reading events from rooms Support UI for ~~MSC2876~~ MSC2872: Widgets reading events from rooms May 14, 2021
@turt2live turt2live changed the title Support UI for ~~MSC2876~~ MSC2872: Widgets reading events from rooms Support UI for <del>MSC2876</del> MSC2872: Widgets reading events from rooms May 14, 2021
@turt2live turt2live changed the title Support UI for <del>MSC2876</del> MSC2872: Widgets reading events from rooms Support UI for MSC2872: Widgets reading events from rooms May 14, 2021
@turt2live turt2live changed the title Support UI for MSC2872: Widgets reading events from rooms Support UI for MSC2762: Widgets reading events from rooms May 14, 2021
@turt2live turt2live requested a review from jryans May 14, 2021 20:19
@turt2live
Copy link
Member Author

@jryans per elsewhere, we're just melding receive and read together.

jryans
jryans approved these changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this, this model seems better overall. 😄

@turt2live turt2live merged commit 3308368 into develop May 17, 2021
@turt2live turt2live deleted the travis/msc2876 branch May 17, 2021 22:26
@turt2live turt2live mentioned this pull request Aug 26, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
Sponsored
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find users Widget API function
2 participants
@turt2live @jryans