This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add new widget API actions for changing rooms and sending/receiving events #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of MSC2762: matrix-org/matrix-spec-proposals#2762 Requires: matrix-org/matrix-widget-api#9 This is the bare minimum required to send an event to a widget and receive events from widgets. Like the view_room action, this is controlled by a well-known permission key. **Danger**: This allows widgets to potentially modify room state. Use the permissions with care.
|
Test failures are expected because the CI doesn't do branch matching on the widget-api (and shouldn't, imo) |
dbkr
reviewed
Nov 11, 2020
dbkr
reviewed
Nov 11, 2020
|
(this side is blocked on internal discussion) |
|
Build is expected to fail until matrix-org/matrix-widget-api#14 lands |
dbkr
approved these changes
Nov 20, 2020
turt2live
added a commit
that referenced
this pull request
Nov 20, 2020
Following #5385, it is now possible for a widget to request these capabilities without being a video conference or sticker picker. This commit actually enables this support for those kinds of widgets. This commit also fixes an issue in the URL templating where some variables might get set to 'undefined' - this appears to be a scoping issue, so StopGapWidget now stores the definition alongside the superclass. Fixes element-hq/element-web#15001
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC for sending/receiving events: matrix-org/matrix-spec-proposals#2762
Requires matrix-org/matrix-widget-api#9 (review first please)Requires matrix-org/matrix-widget-api#14
This is split into individual commits for easy review.
The
view_roomaction is custom to Element and thus has no associated MSC. The send/receive events stuff is aligned with MSC2762 as it is currently written.All of the new actions are controlled by capabilities, with the following dialog introduced:
Note: the actual design is different, however some of the elements we just don't have yet so this is an approximation of that design. The designs cannot be linked publicly.