Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Cypress: add emoji messages to message display Percy screenshots #11775

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Cypress: add emoji messages to message display Percy screenshots #11775

merged 2 commits into from
Oct 23, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Oct 20, 2023 •
edited by github-actions bot
Loading

element-hq/element-web#26401

🚨 auto merge enabled

  • Adds messages containing big emoji and inline emoji to existing 'message display' snapshots for each layout.
  • Removes css assertions

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue labels Oct 20, 2023
@kerryarchibald kerryarchibald requested a review from a team as a code owner October 20, 2023 02:09
@kerryarchibald kerryarchibald changed the title add emoji messages to percy screenshot Cypress: add emoji messages to message display Percy screenshots Oct 20, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2023
@kerryarchibald kerryarchibald removed the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label Oct 23, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 23, 2023
Merged via the queue into develop with commit 124b18b Oct 23, 2023
19 checks passed
@kerryarchibald kerryarchibald deleted the kerry/percy-snapshot-emojis branch October 23, 2023 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @weeman1337