MatrixClient.login no longer stashes the returned access token
#4627
+17
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `MatrixClient.login` had some very unintuitive behaviour where it stashed the access token, but not the device id, refresh token, etc etc, which led people to imagine that they had a functional MatrixClient when they didn't. Ideally we would stash all the returned credentials so that the app doesn't need to make a new MatrixClient, but that's a bit complicated (especially with OIDC) and more than I have time for, so let's at least disable the footgun by not saving *anything*. Fixes: #4502
richvdh
added
the
T-Feature
richvdh
added
T-Enhancement
and removed
T-Feature
|
@richvdh I'd argue this is a breaking change, as consumers may be relying on the current imperfect and inconsistent stashing behaviour |
|
Yeah, possibly. I suppose a better way out of this would be to create a new |
|
closing in favour of #4632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
MatrixClient.loginhad some very unintuitive behaviour where itstashed the access token, but not the device id, refresh token, etc etc, which
led people to imagine that they had a functional MatrixClient when they didn't.
Ideally we would stash all the returned credentials so that the app doesn't
need to make a new MatrixClient, but that's a bit complicated (especially with
OIDC) and more than I have time for, so let's at least disable the footgun by
not saving anything.
Fixes: #4502