Remove MatrixClient.initLegacyCrypto
#4620
Conversation
florianduros
changed the title
MatrixClient.initLegacyCrypto
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-initLegacyCrypto
branch
from
65e817c to
8dcf73c
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-initLegacyCrypto
branch
from
8dcf73c to
ba1ca5c
Compare
|
I imagine that this will have very bad results on our coverage, as you are deleting the tests for code which is not yet deleted. Will this cause any breaches of contract? Do we still have any contracts to uphold coverage beyond a certain level? SonarCloud is only not complaining as it only looks at new code, of which there is none. |
There was a problem hiding this comment.
IMO this should remove all related exported entrypoints, all deprecated & now-unused symbols. Otherwise we will need a 2nd follow-up Breaking Change release to clean up the tech debt to maintain the contract around semver.
.e.g. https://matrix-org.github.io/matrix-js-sdk/enums/matrix.CryptoEvent.html and most things in the crypto dir.
…-initLegacyCrypto # Conflicts: # spec/integ/matrix-client-syncing.spec.ts
There was a problem hiding this comment.
This looks broadly good to me, but I would rather see #4622 / #4624 land first.
I don't agree that we should rip out all of the legacy crypto code at once (and also, ftr, don't agree that removing things in the crypto directory would necessarily result in a major version bump, though it's true that updating CryptoEvent would), but I guess we should discuss that elsewhere.
…-initLegacyCrypto # Conflicts: # spec/integ/sliding-sync-sdk.spec.ts
Checklist
public/exportedsymbols have accurate TSDoc documentation.Task element-hq/element-web#26922
First step to delete definitively the legacy crypto stack. We deprecated during the past months the legacy crypto and now it is time to begin to delete it.
The removal will be in multiple phases and this PR has the unique goal to remove
MatrixClient.initLegacyCrypto, the tests and documentation with direct references.The legacy tests, integration tests, code will be removed or cleaned in other PRs.