Add CryptoApi.resetEncryption
#4614
Open
+115
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
changed the title
CryptoApi#resetEncryptionCryptoApi.resetEncryption
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
f99e069 to
4029eee
Compare
florianduros
added
T-Feature
4 tasks
florianduros
force-pushed
the
florianduros/reset-encryption
branch
2 times, most recently
from
18fb6e6 to
b033611
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
b033611 to
c1462b7
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
c1462b7 to
dbb5c0f
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
dbb5c0f to
0420edf
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
0420edf to
6ea0cd1
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
6ea0cd1 to
dbd54dc
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
dbd54dc to
9f87c04
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
9f87c04 to
be9f401
Compare
florianduros
force-pushed
the
florianduros/reset-encryption
branch
from
be9f401 to
d4e01c9
Compare
andybalaam
approved these changes
Jan 16, 2025
richvdh
reviewed
Jan 17, 2025
Comment on lines
+1919
to
+1927
| // We consider the key backup as trusted | ||
| jest.spyOn(RustBackupManager.prototype, "isKeyBackupTrusted").mockResolvedValue({ | ||
| trusted: true, | ||
| matchesDecryptionKey: true, | ||
| }); | ||
|
|
||
| const rustCrypto = await makeTestRustCrypto(makeMatrixHttpApi(), undefined, undefined, secretStorage); | ||
| // We have a key backup | ||
| expect(await rustCrypto.getActiveSessionBackupVersion()).not.toBeNull(); |
There was a problem hiding this comment.
it might be good to collect all the fetchMock calls together, rather than having this in the middle?
There was a problem hiding this comment.
I don't get it, sorry. rustCrypto.getActiveSessionBackupVersion() is not a fetchMock
Comment on lines
+1919
to
+1923
| // We consider the key backup as trusted | ||
| jest.spyOn(RustBackupManager.prototype, "isKeyBackupTrusted").mockResolvedValue({ | ||
| trusted: true, | ||
| matchesDecryptionKey: true, | ||
| }); |
There was a problem hiding this comment.
is this used before or after the reset?
Can we not use the actual backup data in the response to /_matrix/client/v3/room_keys/version so we don't need to mock this?
There was a problem hiding this comment.
It's used before the reset in order to have a trusted backup.
I suppose there is a better way to have a trusted backup returned by /_matrix/client/v3/room_keys/version?
The backup returned by /_matrix/client/v3/room_keys/version is not trusted in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Task element-hq/element-web#28977
Require #4615
Add
CryptoApi.resetEncryption.The goal of this new api is to give an easy to reset the current encryption state of the user: