Add support for stable name for MSC4115 #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
commented
Jun 6, 2024
| @@ -77,7 +77,6 @@ export interface IUnsigned { | |||
| "invite_room_state"?: StrippedState[]; | |||
| "m.relations"?: Record<RelationType | string, any>; // No common pattern for aggregated relations | |||
| [UNSIGNED_THREAD_ID_FIELD.name]?: string; | |||
| [UNSIGNED_MEMBERSHIP_FIELD.name]?: Membership | string; | |||
There was a problem hiding this comment.
If I try to add both the stable and unstable property names here, the TypeScript checker complains about "A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type." Removing the properties, and using the .findIn method seems to make it happy.
dbkr
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC4115 has been accepted, so enable checking the stable name.
fixes element-hq/element-web#27515
Checklist
public/exportedsymbols have accurate TSDoc documentation.