Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up verification cancel & mismatch for rust crypto #4202

Merged
merged 1 commit into from
May 15, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 15, 2024

@richvdh
Copy link
Member

richvdh commented May 15, 2024

Thank you for picking this up, though it makes me very uneasy that we don't have a test (preferably an end-to-end one, using playwright) for this. The lack of tests is why we have all these rough edges in the first place :(.

@t3chguy
Copy link
Member Author

t3chguy commented May 15, 2024

Fair, I did test it myself, can I sign a deed poll to rename myself to Mr. Playwright or does that not count?

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks plausible

@t3chguy
Copy link
Member Author

t3chguy commented May 15, 2024

I'll add a boring old automated Playwright test on matrix-org/matrix-react-sdk#12526

@richvdh
Copy link
Member

richvdh commented May 15, 2024

FWIW, there's also a not-bad suite of Jest tests for verification at the js-sdk level in spec/intec/crypto/verification.spec.ts, which would also be nice to extend. But given a choice between that and a playwright test, I'd probably prefer the playwright one.

@t3chguy
Copy link
Member Author

t3chguy commented May 15, 2024

Playwright test wired, had to disable it for legacy crypto as that doesn't show the expected mismatch modal and only shows the cancelled state as it does not set the cancellationCode as expected. Given its legacy and hopefully being ditched soon I don't think its worth digging into further.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you t3chguy!

@t3chguy t3chguy added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit 51fa186 May 15, 2024
32 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/27394 branch May 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelling a SAS verification gives infinispinner
3 participants