-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up verification cancel & mismatch for rust crypto #4202
Conversation
Signed-off-by: Michael Telatynski <[email protected]>
Thank you for picking this up, though it makes me very uneasy that we don't have a test (preferably an end-to-end one, using playwright) for this. The lack of tests is why we have all these rough edges in the first place :(. |
Fair, I did test it myself, can I sign a deed poll to rename myself to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks plausible
I'll add a boring old automated Playwright test on matrix-org/matrix-react-sdk#12526 |
FWIW, there's also a not-bad suite of Jest tests for verification at the js-sdk level in |
Playwright test wired, had to disable it for legacy crypto as that doesn't show the expected mismatch modal and only shows the cancelled state as it does not set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you t3chguy!
Fixes element-hq/element-web#27394