-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit events during migration from libolm #3982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/element-r/migration/core
branch
from
January 3, 2024 16:11
cbac65f
to
aa91272
Compare
richvdh
force-pushed
the
rav/element-r/migration/progress
branch
2 times, most recently
from
January 3, 2024 17:06
96db724
to
33df47b
Compare
richvdh
force-pushed
the
rav/element-r/migration/core
branch
2 times, most recently
from
January 8, 2024 14:45
8c1e897
to
7252f7e
Compare
richvdh
force-pushed
the
rav/element-r/migration/progress
branch
from
January 8, 2024 14:46
33df47b
to
8be187f
Compare
richvdh
force-pushed
the
rav/element-r/migration/progress
branch
2 times, most recently
from
January 8, 2024 19:02
1244cec
to
ceb87ea
Compare
richvdh
force-pushed
the
rav/element-r/migration/progress
branch
2 times, most recently
from
January 10, 2024 17:38
7a0ecf1
to
99aca34
Compare
richvdh
requested review from
dbkr,
florianduros and
a team
and removed request for
a team
January 10, 2024 17:45
florianduros
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
andybalaam
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I understand this stuff.
This was apparently never tested, and was implemented incorrectly.
richvdh
force-pushed
the
rav/element-r/migration/progress
branch
from
January 16, 2024 13:26
99aca34
to
92ebb98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that we can display progress feedback in the UI.
part of element-hq/element-web#26773
Here's what your changelog entry will look like:
✨ Features