Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Fix nil pointer derefernce issues #3379

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Fix nil pointer derefernce issues #3379

merged 2 commits into from
Jul 27, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented May 22, 2024

Discovered while running https://gitlab.futo.org/load-testing/matrix-goose.

Dendrite locks up and runs into context cancelled, so the error is not sql.ErrNoRows nor "default" (and definitely shouldn't return that the account exists in this case)

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label May 22, 2024
@S7evinK S7evinK requested a review from a team as a code owner May 22, 2024 18:44
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (46902e5) to head (be13f7a).
Report is 1 commits behind head on main.

Files Patch % Lines
...oomserver/storage/postgres/user_room_keys_table.go 0.00% 1 Missing and 1 partial ⚠️
roomserver/storage/sqlite3/user_room_keys_table.go 0.00% 1 Missing and 1 partial ⚠️
userapi/internal/user_api.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   67.51%   67.49%   -0.02%     
==========================================
  Files         521      521              
  Lines       47366    47371       +5     
==========================================
- Hits        31977    31975       -2     
- Misses      11405    11410       +5     
- Partials     3984     3986       +2     
Flag Coverage Δ
unittests 52.70% <16.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit affb697 into main Jul 27, 2024
19 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/fix-npes branch July 27, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants