Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements around TLS host connection and translations #241

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Jun 14, 2024

Description:

A customer noticed a couple warnings. Also added a note to the host field help text about using a TLS connection. This PR is to address those. While addressing those, it was discovered that the settings weren't translated. So, this adds all of the system settings to the the list of strings that can be translated.

Addresses issue: #108

Review

@snake14 snake14 requested a review from a team June 14, 2024 01:37
@snake14 snake14 changed the title Pg 3545 some minor improvements Improvements around TLS host connection and translations Jun 14, 2024
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange locally the SystemSettings tab looks good
Screenshot from 2024-06-14 08-16-22

Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and I can confirm that the queued tracking is working as expected, but you need to fix the failing testcases before merging.

@snake14
Copy link
Contributor Author

snake14 commented Jun 14, 2024

Thank you @AltamashShaikh I fixed the failing test cases and bumped the version number so that it can be released on Monday.

@snake14 snake14 merged commit 2b8cb1b into 5.x-dev Jun 14, 2024
5 checks passed
@snake14 snake14 deleted the PG-3545-some-minor-improvements branch June 14, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants