remove rgeos dependency by replacing rgeos::gBuffer with sf::st_buffer, fixes #15 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcosci , hi, this is a kind reminder about the quick fix that will allow to return the package back to CRAN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15 .
I have replaced
rgeos::gBufferwithsf::st_buffereffectively removing the dependency on deprecatedrgeospackage. This solves the issue with not being able to install the package even from GitHub, asrgeosis not installable anymore without some hoops. Hopefully, this will also help with restoring the package to CRAN.