Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to swift-markdown #3

Merged
merged 8 commits into from
Mar 12, 2022
Merged

Switch to swift-markdown #3

merged 8 commits into from
Mar 12, 2022

Conversation

nighthawk
Copy link
Member

@nighthawk nighthawk commented Mar 9, 2022 •
edited
Loading

Changes:

  • Removes embedded cmark in favour of apple/swift-cmark
  • Removes AST code in favour of apple/swift-markdown
  • Removes DebugVisitor in favour of document.debugDescription() from swift-markdown

Regressions:

  • Restore style of nested block quotes
  • Restore testing of TestDownView.bundle

Later:

nighthawk added 3 commits March 9, 2022 23:23
@nighthawk
WIP on much simpler Down, by using swift-markdown
759b6a2
@nighthawk
Restore DownView
4efe0ed
@nighthawk
WIP
b32ce88 
- Restore ListPrefixGenerator
- Fix default soft break
@nighthawk nighthawk marked this pull request as draft March 9, 2022 23:52
@nighthawk nighthawk changed the title WIP on much simpler Down, by using swift-markdown Depend on swift-markdown Mar 9, 2022
@nighthawk nighthawk changed the title Depend on swift-markdown Switch to swift-markdown Mar 9, 2022
@nighthawk nighthawk self-assigned this Mar 9, 2022
@nighthawk nighthawk marked this pull request as ready for review March 12, 2022 02:20
@nighthawk nighthawk merged commit 909b4c6 into gfm Mar 12, 2022
@nighthawk nighthawk deleted the swift-markdown branch March 12, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nighthawk nighthawk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nighthawk