FLASH PR - Pin Pyright Version to 1.1.391 #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning version of Pyright to version 1.1.391 as the most recent version of pyright published, 1.1.392 picks up the following two errors `reportGeneralTypeIssues`'s: ```bash mantidimaging/gui/windows/live_viewer/presenter.py mantidimaging/gui/windows/live_viewer/presenter.py:122:18 - error: Object of type "NoReturn" cannot be used with "with" because it does not correctly implement __enter__ (reportGeneralTypeIssues) mantidimaging/gui/windows/live_viewer/presenter.py:122:18 - error: Object of type "NoReturn" cannot be used with "with" because it does not correctly implement __exit__ (reportGeneralTypeIssues) 2 errors, 0 warnings, 0 informations ``` Going forward, this should be explored further, but pinning as a temporary fix for the moment.
ashleymeigh2
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
FLASH PR
Description
Pinning version of Pyright to version 1.1.391 as the most recent version of pyright published, 1.1.392 picks up the following two errors
reportGeneralTypeIssues's:Going forward, this should be explored further, but pinning as a temporary fix for the moment.
Testing
reportGeneralTypeIssuespyright errors present inmantidimaging/gui/windows/live_viewer/presenter.pywere returnedenvironment.yml. Rebuilt developer environment, ran pyright static analysis checks again and verified that the pyrightreportGeneralTypeIssueserrors were no longer returned.Acceptance Criteria
On main branch:
mamba deactivatepython setup.py create_dev_envmamba activate mantidimaging-devpyrightSwitch to PR branch:
git switch pyright_pin_versionmamba deactivatepython setup.py create_dev_envmamba activate mantidimaging-devpyrightreportGeneralTypeIssuespreviously seen on main are no longer returned.Documentation
N/A - Not needed