Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bin Size Validation Logic in RITS Export #2460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Bin Size Validation Logic in RITS Export #2460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release_notes/next/fix-2420-rits-export-error-bin-step-equal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2420: corrected RITS export error when bin size equals step size
2 changes: 1 addition & 1 deletion mantidimaging/gui/windows/spectrum_viewer/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def validate_bin_and_step_size(self, roi: SensibleROI, bin_size: int, step_size:
"""
if bin_size and step_size < 1:
raise ValueError("Both bin size and step size must be greater than 0")
if bin_size <= step_size:
if bin_size < step_size:
raise ValueError("Bin size must be larger than or equal to step size")
if bin_size and step_size > min(roi.width, roi.height):
raise ValueError("Both bin size and step size must be less than or equal to the ROI size")
Expand Down
Loading