Live Viewer calculates intensity of live images via QThreads #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e buffered into the spectrum
…r.update_image_list
…_from_cache_THEN_image_is_not_in_cache and test_WHEN_oldest_image_got_THEN_get_oldest_image
…added_to_cache, test_WHEN_image_in_cache_when_loaded_then_image_taken_from_cache, test_WHEN_cache_full_THEN_loading_image_removes_oldest_image
…g deleted prematurely
…d, test_WHEN_roi_set_enabled_THEN_roi_enabled, test_WHEN_nans_in_mean_THEN_handle_roi_change_timer_start, test_WHEN_no_nans_in_mean_THEN_handle_roi_change_timer_not_started
MikeSullivan7
force-pushed
the
2448_live_viewer_spectrum_async
branch
from
cc43f76 to
c53660e
Compare
MikeSullivan7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2448
Description
The calculation of the Intensity Profile in the Live Viewer is now done asynchronously via a QThread and the GUI is updated via the main thread upon the QThread termination. The intensity is calculated in chunks of 100 points, each done via a different thread. It is done in this way so that the GUI will remain responsive and smooth while the ROI is moved on the image, all while the intensity updates to the new position. The calculation speed is also increased by using the
ImageCacheclass.Unit and System tests have been added for the Live Viewer.
This PR will require PR #2425 after which this PR will need to be rebased.
Testing
make checkmake test-systemAcceptance Criteria
Check that all tests pass.
Documentation
Release Note