Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrum window tabs #2452

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Spectrum window tabs #2452

merged 5 commits into from
Jan 14, 2025

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Jan 9, 2025

Issue

Closes #2383

Description

This moves all of the form side into a QTabWidget, and the image side into a QStackedWidget. Change tabs changes the visible page of the stacked widget.

Note: there is an option on the changes page to view the diff with whitespace changes hidden, which helps for the xml file.

Testing

Applitools screenshots updated

Acceptance Criteria

Check that the tabs are visible, and that you can switch between tabs

Documentation

Not needed

@samtygier-stfc
Copy link
Collaborator Author

This introduces a GUI change, the new tabs
image

And makes other widgets shift by a few pixels
image

@samtygier-stfc samtygier-stfc marked this pull request as ready for review January 10, 2025 13:32
@samtygier-stfc samtygier-stfc force-pushed the 2383-sepectrum-window-tabs branch from 63395de to 94f10b2 Compare January 10, 2025 13:37
@coveralls
Copy link

coveralls commented Jan 10, 2025

Coverage Status

coverage: 73.609% (-0.01%) from 73.622%
when pulling 94f10b2 on 2383-sepectrum-window-tabs
into 3f099d2 on main.

Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I have manually tested and can confirm the tabs are now present and change the layout on selection.

@JackEAllen JackEAllen added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 41617ac Jan 14, 2025
8 checks passed
@JackEAllen JackEAllen deleted the 2383-sepectrum-window-tabs branch January 14, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All Windows: Create Window Tab Selection to Access Image, Fitting and Export Windows
3 participants