Unify datasets 10: Remove StrictDataset #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2199-unify-datasets-10
branch
from
66005d7 to
4963366
Compare
This used to be used to filter datasets by type, but that is no longer needed since the unification. The test_do_reload_datasets_by_dataset_type() test is also no loner needed.
…asetSelectorWidgetPresenterTests, SpectrumViewerWindowPresenterTest
samtygier-stfc
force-pushed
the
2199-unify-datasets-10
branch
from
4963366 to
2b7887a
Compare
JackEAllen
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
The changes look good. Thank you for your hard work refactoring Mixed and Strict Dataset into a generic Dataset class. Overall, working with datasets will be much easier. I have ran unit tests and tested manually with a few different datasets including saving and loading of nexus datasets.
Happy to approve 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2199
Needs rebase after #2401Description
This completes the task of unifying the MixedDataset and StrictDataset into Dataset
Migrates the last few places using StrictDataset.
Testing
Has updates to some tests
Acceptance Criteria
Test opening a dataset from Tiffs.
Test opening and saving from nexus files (but fix #2404 first)
Documentation
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes