Added Type checking to the liveviewer and recon #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Jul 4, 2024
There was a problem hiding this comment.
The tests are failing with the following ruff errors
mantidimaging/gui/windows/recon/model.py:140:93: F821 Undefined name `ReconstructedObject`
mantidimaging/gui/windows/recon/point_table_model.py:6:25: F401 `typing.Optional` imported but unused
mantidimaging/gui/windows/recon/point_table_model.py:6:35: F401 `typing.Union` imported but unused
Signed-off-by: ashmeigh <[email protected]>
samtygier-stfc
requested changes
Jul 16, 2024
Signed-off-by: ashmeigh <[email protected]>
samtygier-stfc
requested changes
Jul 22, 2024
samtygier-stfc
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added type annotations to various files within the mantidimaging/gui/windows directory to enhance type safety and improve code maintainability. These annotations ensure clearer function signatures and better compatibility with Python type checkers like mypy.
Testing
Type annotations do not introduce runtime errors.
Functionality across affected modules remains intact.
All affected code paths are adequately covered by existing unit tests.
Acceptance Criteria
No linting errors related to type annotations.
No type-related runtime errors occur during testing.
All affected code paths are adequately covered by existing tests.