changing operations to compute function #2066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,8 +30,8 @@ class RebinFilter(BaseFilter): | |||
| filter_name = "Rebin" | |||
| link_histograms = True | |||
|
|
|||
| @staticmethod | |||
| def filter_func(images: ImageStack, rebin_param=0.5, mode=None, progress=None) -> ImageStack: | |||
| @classmethod | |||
There was a problem hiding this comment.
change back to staticmethod
| progress=progress) | ||
| images.shared_array = empty_resized_data | ||
| params = {'new_shape': new_shape, 'mode': mode} | ||
| ps.run_compute_func(cls.compute_function, images.data.shape[0], images.shared_array, params, progress) |
There was a problem hiding this comment.
ps.run_compute_func(RebinFilter.compute_function, images.data.shape[0], [images.shared_array, empty_resized_data], params, progress)
|
|
||
| empty_resized_data = _create_reshaped_array(images, rebin_param) |
Comment on lines
61
to
64
| def compute_function(i: int, array: np.ndarray, params: dict): | ||
| new_shape = params['new_shape'] | ||
| mode = params['mode'] | ||
| array[i] = resize(array[i], output_shape=new_shape, mode=mode, preserve_range=True) |
There was a problem hiding this comment.
def compute_function(i: int, arrays: list[np.ndarray], params: dict):
new_shape = params['new_shape']
mode = params['mode']
input_array, output_array = arrays
output_array[i] = resize(input_array[i], output_shape=new_shape, mode=mode, preserve_range=True)
There was a problem hiding this comment.
AttributeError: 'numpy.ndarray' object has no attribute 'has_shared_memory'
i have changed the code to fix this
|
Split into other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request implements a significant shift in how operations are executed within our project, addressing issue. the code is moving from a partial function execution style to adopting a
compute_functionmethod across various operations. This transition facilitates a clearer separation between the setup and execution phases of operations.Key Changes:
compute_functionstatic method in multiple operation classes, standardising the execution approach. This method encapsulates the core logic for operation execution on a per-slice basis.compute_functionmethod, ensuring all operations are compatible with this standardised approach.compute_function