Flash PR - Rename Sample Log to Sample / Spectra Log in Load Dialog Menu #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackEAllen
force-pushed
the
rename_log_file_load_dialog
branch
from
260c7b5 to
ccd3494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sample log in the load dialog menu is used to load both a sample log containing angles or a spectra log for TOF datasets.
We received feedback that loading a spectra file here is not intuitive if the name is called "Sample Log".
Description
This issue aims to add more context to the load dialog menu by renaming to "Sample / Spectra Log" which is a more descriptive name for the type of file that can be loaded here.
Testing
Opened load dialog and verified name has been altered from "Sample Log" to "Sample / Spectra Log"
Acceptance Criteria
Load dialog window "Sample Log" has been renamed to "Sample / Spectra Log"
Documentation
NA