Add Type Annotations for Improved Type Safety in Windows (#2251)

mantidimaging/gui/windows/add_images_to_dataset_dialog/presenter.py

@@ -23,21 +23,21 @@ def __init__(self, view: AddImagesToDatasetDialog):
         super().__init__(view)
         self._images = None
 
-    def notify(self, n: Notification):
+    def notify(self, n: Notification) -> None:
         try:
             if n == Notification.IMAGE_FILE_SELECTED:
                 self.load_images()
         except RuntimeError as err:
             self.view.show_exception(str(err), traceback.format_exc())
 
-    def load_images(self):
+    def load_images(self) -> None:
         """
         Loads the images from the file path provided by the user.
         """
         start_async_task_view(self.view, self.view.parent_view.presenter.model.load_image_stack,
                               self._on_images_load_done, {'file_path': self.view.path})
 
-    def _on_images_load_done(self, task: TaskWorkerThread):
+    def _on_images_load_done(self, task: TaskWorkerThread) -> None:
         """
         Checks if loading images was successful and then triggers the necessary updates.
         :param task: The file loading task.

mantidimaging/gui/windows/add_images_to_dataset_dialog/view.py

@@ -33,10 +33,10 @@ def __init__(self, parent, dataset_id: uuid.UUID, strict_dataset: bool, dataset_
         self.buttonBox.button(QDialogButtonBox.Ok).setEnabled(False)
         self.accepted.connect(self._on_accepted)
 
-    def _on_accepted(self):
+    def _on_accepted(self) -> None:
         self.presenter.notify(Notification.IMAGE_FILE_SELECTED)
 
-    def choose_file_path(self):
+    def choose_file_path(self) -> None:
         """
         Select a file in the stack path that we wish to add/replace in the dataset.
         """

mantidimaging/gui/windows/image_load_dialog/presenter.py

@@ -74,7 +74,7 @@ def do_update_sample(self, selected_file: str) -> None:
                 if related_group:
                     self.update_field_with_filegroup(file_info, related_group)
 
-    def update_field_with_filegroup(self, file_info: FILE_TYPES, file_group: FilenameGroup):
+    def update_field_with_filegroup(self, file_info: FILE_TYPES, file_group: FilenameGroup) -> None:
         """
         Update the field with the given file group by finding all files in the group and setting them in the field.
 

mantidimaging/gui/windows/move_stack_dialog/view.py

@@ -36,7 +36,7 @@ def __init__(self, parent, origin_dataset_id: uuid.UUID, stack_id: uuid.UUID, or
         self.datasetSelector.subscribe_to_main_window(parent)
         self._on_destination_dataset_changed()
 
-    def accept(self):
+    def accept(self) -> None:
         self.presenter.notify(Notification.ACCEPTED)
         self.close()
 

mantidimaging/gui/windows/welcome_screen/presenter.py

@@ -29,13 +29,13 @@ def __init__(self, parent=None, view=None):
 
         self.do_set_up()
 
-    def do_set_up(self):
+    def do_set_up(self) -> None:
         self.view.set_version_label(f"Mantid Imaging {versions.get_version()}")
         self.set_up_links()
         self.set_up_show_at_start()
         self.check_issues()
 
-    def show(self):
+    def show(self) -> None:
         self.view.show()
 
     @staticmethod
@@ -55,26 +55,26 @@ def show_today():
         else:
             return show_at_start
 
-    def set_up_links(self):
+    def set_up_links(self) -> None:
         for link_name, url in WELCOME_LINKS:
             self.add_link(link_name, url)
 
-    def add_link(self, link_name, url):
+    def add_link(self, link_name: str, url: str) -> None:
         rich_text = f'<a href="{url}">{link_name}</a>'
         self.view.add_link(rich_text, self.link_count)
         self.link_count += 1
 
-    def set_up_show_at_start(self):
+    def set_up_show_at_start(self) -> None:
         show_at_start = WelcomeScreenPresenter.show_at_start_enabled()
         self.view.set_show_at_start(show_at_start)
         self.show_at_start_changed()
 
-    def show_at_start_changed(self):
+    def show_at_start_changed(self) -> None:
         show_at_start = self.view.get_show_at_start()
         self.settings.setValue("welcome_screen/show_at_start", show_at_start)
         self.settings.setValue("welcome_screen/last_run_version", versions.get_version())
 
-    def check_issues(self):
+    def check_issues(self) -> None:
         issues = []
         if versions.needs_update():
             msg, detailed = versions.conda_update_message()

mantidimaging/gui/windows/welcome_screen/view.py

@@ -25,21 +25,21 @@ def __init__(self, parent, presenter):
         self.show_at_start.stateChanged.connect(presenter.show_at_start_changed)
         self.ok_button.clicked.connect(self.close)
 
-    def get_show_at_start(self):
+    def get_show_at_start(self) -> None:
         return self.show_at_start.isChecked()
 
-    def set_show_at_start(self, checked):
+    def set_show_at_start(self, checked: bool) -> None:
         self.show_at_start.setChecked(checked)
 
-    def set_version_label(self, contents):
+    def set_version_label(self, contents: str) -> None:
         self.version_label.setText(contents)
 
-    def add_link(self, label, row):
+    def add_link(self, label: str, row: int) -> None:
         link_label = QLabel(label)
         link_label.setOpenExternalLinks(True)
         self.link_box_layout.addWidget(link_label, row, 0)
 
-    def add_issues(self, contents):
+    def add_issues(self, contents: str) -> None:
         self.issue_box.setVisible(True)
         issues_label = QLabel(contents)
         issues_label.setOpenExternalLinks(True)

mantidimaging/gui/windows/wizard/presenter.py

@@ -32,16 +32,16 @@ def __init__(self, parent: MainWindowView):
         self.handle_stack_change()
         self.show()
 
-    def show(self):
+    def show(self) -> None:
         self.view.show()
 
-    def populate(self):
+    def populate(self) -> None:
         for stage in self.wizard_data["stages"]:
             self.view.add_stage(stage["name"])
             for step in stage["steps"]:
                 self.view.add_step(stage["name"], step)
 
-    def run_action(self, action: str):
+    def run_action(self, action: str) -> None:
         if action == "load":
             self.main_window_presenter.wizard_action_load()