Reverted yielding only non-empty strings in order to stay consistent …

…and not introduce unspecified rule-exceptions.
mandiant · Jul 5, 2022 · 71cb09a · 71cb09a
1 parent e4225c2
commit 71cb09a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/capa/features/extractors/ts/file.py b/capa/features/extractors/ts/file.py
@@ -19,9 +19,7 @@ def extract_language(engine: TreeSitterExtractorEngine) -> Iterator[Tuple[Featur
 def extract_file_strings(engine: TreeSitterExtractorEngine) -> Iterator[Tuple[Feature, Address]]:
     for global_node, _ in engine.get_global_statements():
         for node, _ in engine.get_string_literals(global_node):
-            s = engine.get_range(node).strip('"')
-            if len(s) > 0:
-                yield String(engine.get_range(node).strip('"')), engine.get_address(node)
+            yield String(engine.get_range(node).strip('"')), engine.get_address(node)
 
 
 def extract_file_integer_literals(engine: TreeSitterExtractorEngine) -> Iterator[Tuple[Feature, Address]]:
@@ -60,4 +58,5 @@ def extract_features(engine: TreeSitterExtractorEngine) -> Iterator[Tuple[Featur
     extract_file_integer_literals,
     extract_file_strings,
     extract_language,
+    extract_namespaces,
 )
diff --git a/tests/test_ts_engine.py → tests/test_ts.py b/tests/test_ts_engine.py → tests/test_ts.py