-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use "span of calls" scope #973
base: master
Are you sure you want to change the base?
Conversation
@@ -6,7 +6,7 @@ rule: | |||
- "@_re_fox" | |||
scopes: | |||
static: basic block | |||
dynamic: thread | |||
dynamic: span of calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic: span of calls | |
dynamic: call |
@@ -6,7 +6,7 @@ rule: | |||
- "@_re_fox" | |||
scopes: | |||
static: basic block | |||
dynamic: thread | |||
dynamic: span of calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic: span of calls | |
dynamic: call |
@@ -6,7 +6,7 @@ rule: | |||
- "@_re_fox" | |||
scopes: | |||
static: basic block | |||
dynamic: thread | |||
dynamic: span of calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic: span of calls | |
dynamic: call |
@@ -6,7 +6,7 @@ rule: | |||
- [email protected] | |||
scopes: | |||
static: function | |||
dynamic: thread | |||
dynamic: span of calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic: span of calls | |
dynamic: span of calls |
dynamic: span of calls | |
dynamic: call |
@@ -6,7 +6,7 @@ rule: | |||
- [email protected] | |||
scopes: | |||
static: function | |||
dynamic: thread | |||
dynamic: span of calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic: span of calls | |
dynamic: call |
@@ -6,7 +6,7 @@ rule: | |||
- "@_re_fox" | |||
scopes: | |||
static: function | |||
dynamic: thread | |||
dynamic: span of calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic: span of calls | |
dynamic: call |
@@ -8,7 +8,7 @@ rule: | |||
- [email protected] | |||
scopes: | |||
static: function | |||
dynamic: thread | |||
dynamic: span of calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic: span of calls | |
dynamic: call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot checked ~30 of these rules and the changes look reasonable to me.
Generally, we need to asses the existing capa rules (I don't recommend doing it in this PR) for opportunities to tighten up the scopes (I've left comments on a few of these that I noticed here) to reduce FP (and improve performance??). I imagine this would be implemented as a lint that verifies the scopes specified for a new rule are the smallest possible, accounting for match features and whatnot. We should also add a lint that verifies scopes align correctly for match features, iirc we've encountered this in the past, and I'm sure it'll only be more of an issue as we've added new scopes.
like #972
supporting mandiant/capa#2532