Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add idapro.vm, that installs IDA Pro 9 using an IDA Pro installer
ida-pro_9*.exe
(and optionally a license file) in the Desktop. Make also some changes to idafree.vm to keep both packages consistent.There are some conflicts between idafree.vm and idapro.vm, as both use the same tool name, which enable us to have a single shortcut (in the Tools directory and the taskbar) and right-click menu option. As long as idapro.vm is installed after idafree.vm (which should be the case using the installer that uses alphabetical order), the installation is as I would expect it:
We may be able to merge or improve these two packages as it is clear if we will be able to install IDA Free 9 (tracked in #1150).
I have kept IDA Pro 9 Desktop shortcut as I find it useful to drag binaries to it.
We need to exclude this new package from testing, as we can't provide an IDA installer. I have tested locally with
ida-pro_90_x64win.exe
andida-pro_90sp1_x64win.exe
.Refresh Desktop in the packages whose shortcut is used in FLARE-VM LayoutModification.xml, including the new idapro.vm.
Closes #1225