Formatters for sparrow classes #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-PLACET
force-pushed
the
formatters_for_sparrow_classes
branch
from
0fa2350 to
8802f17
Compare
Alex-PLACET
force-pushed
the
formatters_for_sparrow_classes
branch
2 times, most recently
from
9c1575d to
ed63d2d
Compare
Alex-PLACET
changed the title
Alex-PLACET
requested review from
DerThorsten and
JohanMabille
and removed request for
DerThorsten
Alex-PLACET
force-pushed
the
formatters_for_sparrow_classes
branch
2 times, most recently
from
4545986 to
6960056
Compare
DerThorsten
reviewed
Dec 17, 2024
| { | ||
|
|
||
| return std::format_to(ctx.out(), "[size={}] TODO", list_value.size()); | ||
| // for (std::size_t i = 0; i < list_value.size(); ++i) |
DerThorsten
approved these changes
Dec 17, 2024
include/sparrow/utils/format.hpp
Outdated
| // max with names | ||
| for (size_t i = 0; i < std::ranges::size(headers); ++i) | ||
| { | ||
| #if defined(__clang__) |
There was a problem hiding this comment.
Would a static_cast avoid the warning here? I think it would be easier to read. If not, then maybe a single set of pragma enclosing the whole function would probably improve the readability.
There was a problem hiding this comment.
No because, as headers is a template argument, depend ending of its type, std::ranges::size(headers) will not return the same type, in one case we have teh warning about the sign conversion, in the other a warning about useless static_cast.
There was a problem hiding this comment.
I still think a single set of pragma enclosing the whole function would make it easier to read.
Alex-PLACET
force-pushed
the
formatters_for_sparrow_classes
branch
2 times, most recently
from
55ff0ba to
d25de9a
Compare
Fix Fix Try fix WIP address comments
Alex-PLACET
force-pushed
the
formatters_for_sparrow_classes
branch
from
33a06ad to
2841b40
Compare
JohanMabille
approved these changes
Dec 18, 2024
| // } | ||
| // }; | ||
|
|
||
| // #endif |
There was a problem hiding this comment.
Is that intentional or is it a leftover?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.