Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STS refresh token patch #2111

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

STS refresh token patch #2111

wants to merge 16 commits into from

Conversation

phoebusm
Copy link
Collaborator

@phoebusm phoebusm commented Jan 9, 2025

Reference Issues/PRs

Inherit changes from #2095

What does this implement or fix?

Apart from the python changes inherit from #2095, only changes added is in fix-refresh-sts-token-timing.patch. Others are copied from vcpkg repo.

Before the changes, the token is refreshed only when the token is expired during checking. If the token expire after the check and before calling API, it could take a long time before the SDK returns error.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant