Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prechecks for asv #2107

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Prechecks for asv #2107

wants to merge 25 commits into from

Conversation

grusev
Copy link
Collaborator

@grusev grusev commented Jan 8, 2025

Reference Issues/PRs

What does this implement or fix?

There are couple of checks that need to be done before making sure asv benchmark tests are ok to be merged:

Check that code of tests is ok and can run

asv check --python=same

Checks that versions of benchmark tests are up to date in asv,conf.json

asv run --bench just-discover --python=same

this PR will prepare a script which can be run by anyone before making PR for review as well as github action that will execute it to confirm all is ok

A new python utility is added to do the required checks. Usage:

python python/utils/asv_checks.py

This tool now can be used in a github action to do automatic check

Successfull check of Job: https://github.com/man-group/ArcticDB/actions/runs/12713349006/job/35441035657

A job failed because benchmark.json not up to date: https://github.com/man-group/ArcticDB/actions/runs/12711972129/job/35436505808

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@grusev grusev force-pushed the asv_slow branch 2 times, most recently from b00e8e9 to f23a441 Compare January 9, 2025 16:01
@grusev grusev force-pushed the asv_slow branch 2 times, most recently from ca077d4 to 3553540 Compare January 10, 2025 09:21
@grusev grusev marked this pull request as ready for review January 10, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant