-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prechecks for asv #2107
Open
grusev
wants to merge
25
commits into
master
Choose a base branch
from
asv_slow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prechecks for asv #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grusev
force-pushed
the
asv_slow
branch
2 times, most recently
from
January 9, 2025 16:01
b00e8e9
to
f23a441
Compare
grusev
force-pushed
the
asv_slow
branch
2 times, most recently
from
January 10, 2025 09:21
ca077d4
to
3553540
Compare
grusev
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
January 10, 2025 18:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
There are couple of checks that need to be done before making sure asv benchmark tests are ok to be merged:
Check that code of tests is ok and can run
Checks that versions of benchmark tests are up to date in asv,conf.json
this PR will prepare a script which can be run by anyone before making PR for review as well as github action that will execute it to confirm all is ok
A new python utility is added to do the required checks. Usage:
This tool now can be used in a github action to do automatic check
Successfull check of Job: https://github.com/man-group/ArcticDB/actions/runs/12713349006/job/35441035657
A job failed because benchmark.json not up to date: https://github.com/man-group/ArcticDB/actions/runs/12711972129/job/35436505808
Any other comments?
Checklist
Checklist for code changes...