[montreal_ca] Updating to support different sectors #3372
+230
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fortinm <[email protected]>
|
@julienboriasse This was originally written by you, I had to modify as there are 5 different sector ids in my area. |
|
Nice, j'utilisais l'option multiple sources jusqu'à présent, mais cette solution est meilleure! |
|
@mampfes can this gets a review ? I have been using this updated code in my local HA installation and won't update for the time being |
|
@5ila5 care for a review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waste routes could be named differently for a given post code.
This PR allows specifying different sectors per waste types, all while retaining the existing behaviour of only having "sector" being set.
In the event only sector is defined, it will be used for all waste management.
Updated documentation to reflect changes.
Added test cases.