Metrics #73
Closed
Metrics #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baliedge
force-pushed
the
Baliedge/metrics
branch
from
5331bd6 to
f9eea5f
Compare
thrawn01
reviewed
Dec 4, 2024
| Objectives: SummaryObjectives, | ||
| }, []string{"group", "peer"}) | ||
| metricUpdatePeerLatency = prometheus.NewSummaryVec(prometheus.SummaryOpts{ | ||
| Name: "groupcache_update_peer_latency", |
There was a problem hiding this comment.
Probably should be called groupcache_set_peer_latency 😃
Baliedge
force-pushed
the
Baliedge/metrics
branch
from
49af3e3 to
ca02586
Compare
Baliedge
force-pushed
the
Baliedge/metrics
branch
from
ca02586 to
72a8db8
Compare
|
I am using this exporter to collect metrics from groupcache in prometheus format while keeping prometheus metrics decoupled from groupcache: |
|
Closing in favor of existing metrics solution: https://github.com/udhos/groupcache_exporter Thanks, @udhos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase visibility of cache state and performance with Prometheus metrics.
Upstream deps must register metrics returned by
GetMetrics().Metrics
Peer to peer
groupcache_get_from_peer_latency{group}: The latency in seconds getting value from remote peergroupcache_set_peer_latency{group}: The latency in seconds during peer update after a SetCache stats
typedenotes cache typemainorhot.groupcache_stats_bytes{group, type}: The number of bytes stored in cachegroupcache_stats_items{group, type}: The number of items stored in cachegroupcache_stats_gets{group, type}: The count of get requestsgroupcache_stats_hits{group, type}: The count of cache hitsgroupcache_stats_evictions{group, type}: The count of cache evictions