Docs and nodejs #2582
Closed
Docs and nodejs #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
grumbach
reviewed
Dec 31, 2024
ant-bootstrap/tests/cache_tests.rs
Outdated
| tokio::fs::write(&cache_path, "invalid json content").await?; | ||
|
|
||
| // Create a new cache store - it should handle the corruption gracefully |
There was a problem hiding this comment.
I find these comments to be very helpful when reading tests. Any specific reason to remove those?
ant-local-testnet-action
Outdated
| @@ -0,0 +1 @@ | |||
| Subproject commit 600912168508b206c51f974440d2316b06618a98 | |||
There was a problem hiding this comment.
This seemed to be a ci file, but I had a git issue so could not tell, so I left it in place in case it was used
autonomi/src/client/data/public.rs
Outdated
| header.kind | ||
| ); | ||
| Err(NetworkError::RecordKindMismatch(RecordKind::Chunk).into()) | ||
| ClientMode::ReadOnly => Err(PutError::NoWallet), |
There was a problem hiding this comment.
What does the mode protect us against? I'm wondering if it would be simpler without them?
autonomi/src/client/mod.rs
Outdated
| } | ||
|
|
||
| /// Check if the client has write access (i.e. has a wallet) | ||
| pub fn check_write_access(&self) -> Result<(), PutError> { |
There was a problem hiding this comment.
I feel like all this complexity can be removed if we get rid of the mode
grumbach
reviewed
Dec 31, 2024
ant-local-testnet-action
Outdated
dirvine
force-pushed
the
docs_and_nodejs
branch
from
395a13a to
f92438c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js Integration, Documentation Enhancement, and AttoTokens Fix
Overview
This PR introduces comprehensive documentation, Node.js integration capabilities, and fixes a critical issue with AttoTokens parsing. The changes aim to improve developer experience, expand platform accessibility, and enhance system reliability.
Key Changes
Documentation Enhancements
Node.js Integration
Bug Fixes
Infrastructure Improvements
.gitignoreto handle Node.js and documentation artifactsTesting
Impact
These changes significantly improve the project's accessibility and reliability:
Breaking Changes
None. All changes are backward compatible.
Future Work
Checklist