fix(node): notify fetch completion earlier to avoid being skipped #1737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is trying to avoid false
failed to fetch
alert, which occasionally happens within thelocation verify
CI test.The root reason is because of interleaved processes, there is chance that a previously un-available record becomes stored during fetch it. Which case the
replication fetcher
not get notified of the completion.To resolve it, the completion of the fetch will always trigger a notification to be sent to replication_fetcher, on receive a fetch response.
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change
Please mark the types of changes made in this pull request.
Checklist
Please ensure all of the following tasks have been completed: