Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): notify fetch completion earlier to avoid being skipped #1737

Merged
merged 1 commit into from
May 20, 2024

Conversation

maqi
Copy link
Member

@maqi maqi commented May 20, 2024

Description

This PR is trying to avoid false failed to fetch alert, which occasionally happens within the location verify CI test.
The root reason is because of interleaved processes, there is chance that a previously un-available record becomes stored during fetch it. Which case the replication fetcher not get notified of the completion.
To resolve it, the completion of the fetch will always trigger a notification to be sent to replication_fetcher, on receive a fetch response.

Related Issue

Fixes #<issue_number> (if applicable).

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@RolandSherwin RolandSherwin enabled auto-merge May 20, 2024 16:09
@RolandSherwin RolandSherwin added this pull request to the merge queue May 20, 2024
@maqi maqi force-pushed the fix_avoid_false_failed_fetch_alert branch from 379c769 to 20b90af Compare May 20, 2024 16:27
@maqi maqi removed this pull request from the merge queue due to a manual request May 20, 2024
@maqi maqi enabled auto-merge May 20, 2024 16:28
@maqi maqi added this pull request to the merge queue May 20, 2024
Merged via the queue into maidsafe:main with commit c63a34f May 20, 2024
35 checks passed
@maqi maqi deleted the fix_avoid_false_failed_fetch_alert branch May 20, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants