feat: use default keys, or override #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
force-pushed
the
KeyManagementUpdates
branch
from
96a7965 to
f24584d
Compare
joshuef
changed the title
joshuef
force-pushed
the
KeyManagementUpdates
branch
3 times, most recently
from
7283af7 to
573ddf7
Compare
maqi
requested changes
May 20, 2024
maqi
reviewed
May 20, 2024
| @@ -30,8 +30,9 @@ const GENESIS_DERIVATION_INDEX: DerivationIndex = DerivationIndex([0u8; 32]); | |||
|
|
|||
| /// Default genesis SK for testing purpose. Be sure to pass the correct `GENESIS_PK` value via env. | |||
There was a problem hiding this comment.
comment needs to be updated once this PR merged.
joshuef
force-pushed
the
KeyManagementUpdates
branch
from
573ddf7 to
3db7f65
Compare
joshuef
force-pushed
the
KeyManagementUpdates
branch
from
3db7f65 to
5550cf5
Compare
joshuef
force-pushed
the
KeyManagementUpdates
branch
from
06cb0b4 to
d2f20ad
Compare
maqi
approved these changes
May 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves changes to the handling of the
GENESIS_PKandGENESIS_SKenvironment variables in various GitHub workflow files and in thesn_transfers/src/genesis.rsfile. The key changes include the removal of hardcodedGENESIS_PKvalues in several workflow files, a change in the hardcodedGENESIS_PKvalue inmerge.yml, and changes to the default handling of these environment variables ingenesis.rs.Environment Variables:
.github/workflows/benchmark-prs.yml,.github/workflows/generate-benchmark-charts.yml,.github/workflows/memcheck.yml,.github/workflows/nightly.yml,.github/workflows/nightly_wan.yml, and.github/workflows/nightly_wan_churn.yml: Removed hardcodedGENESIS_PKfrom theenv:block. [1] [2] [3] [4] [5] [6].github/workflows/merge.yml: Changed hardcodedGENESIS_PKvalue in theenv:block and addedGENESIS_SK.Codebase Modifications:
sn_transfers/src/genesis.rs: Modified the handling ofGENESIS_PKandGENESIS_SKenvironment variables. If these variables are not set, a warning is issued and default values are used for testing purposes. Also, theLIVE_GENESIS_PKconstant was renamed toDEFAULT_LIVE_GENESIS_PKand its value was changed. [1] [2] [3]