Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-launchpad): tweaks on resource allocation widget #1714

Merged
merged 1 commit into from
May 16, 2024
Merged

feat(node-launchpad): tweaks on resource allocation widget #1714

merged 1 commit into from
May 16, 2024

Conversation

mazzi
Copy link
Contributor

@mazzi mazzi commented May 16, 2024

  • Added support for arrow up/down to increment/decrement allocated space.
  • Validation when using arrow up/down to avoid going over/under available disk space.
  • Minor widget styling: removed cursor, centered title, footer and input field.
  • Created some constants.

@mazzi mazzi requested a review from RolandSherwin May 16, 2024 09:31
RolandSherwin
RolandSherwin approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@RolandSherwin RolandSherwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great 🚀

@RolandSherwin RolandSherwin enabled auto-merge May 16, 2024 09:50
@mazzi mazzi force-pushed the node-launchpad_resource_allocation_ui_improvements branch 3 times, most recently from 50d005b to 0e0fbac Compare May 16, 2024 10:54
@mazzi
feat(node-launchpad): tweaks on resource allocation widget
b7b43c9 
Added support for arrow up/down to increment/decrement allocated space.
Validation when using arrow up/down to avoid going over/under available disk space.
Minor widget styling: removed cursor, centered title, footer and input field.
Created some constants.
@mazzi mazzi force-pushed the node-launchpad_resource_allocation_ui_improvements branch from 0e0fbac to b7b43c9 Compare May 16, 2024 10:56
@RolandSherwin RolandSherwin added this pull request to the merge queue May 16, 2024
Merged via the queue into maidsafe:main with commit 9812d39 May 16, 2024
34 checks passed
@mazzi mazzi deleted the node-launchpad_resource_allocation_ui_improvements branch May 16, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolandSherwin RolandSherwin RolandSherwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazzi @RolandSherwin