feat(node): prevent free upload via replication

This is achieved by: * only trust replication source with enough healthy status * when not having enough healthy knowledge, only trust majority
maidsafe · Jan 17, 2025 · 0b897b2 · 0b897b2
1 parent 1770122
commit 0b897b2
Show file tree

Hide file tree

Showing 5 changed files with 285 additions and 90 deletions.
diff --git a/ant-networking/src/cmd.rs b/ant-networking/src/cmd.rs
@@ -153,6 +153,10 @@ pub enum LocalSwarmCmd {
     AddNetworkDensitySample {
         distance: Distance,
     },
+    /// Send peer scores (collected from storage challenge) to replication_fetcher
+    NotifyPeerScores {
+        peer_scores: Vec<(PeerId, bool)>,
+    },
 }
 
 /// Commands to send to the Swarm
@@ -312,6 +316,9 @@ impl Debug for LocalSwarmCmd {
             LocalSwarmCmd::AddNetworkDensitySample { distance } => {
                 write!(f, "LocalSwarmCmd::AddNetworkDensitySample({distance:?})")
             }
+            LocalSwarmCmd::NotifyPeerScores { peer_scores } => {
+                write!(f, "LocalSwarmCmd::NotifyPeerScores({peer_scores:?})")
+            }
         }
     }
 }
@@ -932,6 +939,10 @@ impl SwarmDriver {
                 cmd_string = "AddNetworkDensitySample";
                 self.network_density_samples.add(distance);
             }
+            LocalSwarmCmd::NotifyPeerScores { peer_scores } => {
+                cmd_string = "NotifyPeerScores";
+                self.replication_fetcher.add_peer_scores(peer_scores);
+            }
         }
 
         self.log_handling(cmd_string.to_string(), start.elapsed());

diff --git a/ant-networking/src/event/request_response.rs b/ant-networking/src/event/request_response.rs
@@ -46,7 +46,7 @@ impl SwarmDriver {
                                 channel: MsgResponder::FromPeer(channel),
                             });
 
-                            self.add_keys_to_replication_fetcher(holder, keys);
+                            self.add_keys_to_replication_fetcher(holder, keys, false);
                         }
                         Request::Cmd(ant_protocol::messages::Cmd::PeerConsideredAsBad {
                             detected_by,
@@ -160,6 +160,7 @@ impl SwarmDriver {
         &mut self,
         sender: NetworkAddress,
         incoming_keys: Vec<(NetworkAddress, ValidationType)>,
+        is_fresh_replicate: bool,
     ) {
         let holder = if let Some(peer_id) = sender.as_peer_id() {
             peer_id
@@ -192,9 +193,9 @@ impl SwarmDriver {
             .kademlia
             .store_mut()
             .record_addresses_ref();
-        let keys_to_fetch = self
-            .replication_fetcher
-            .add_keys(holder, incoming_keys, all_keys);
+        let keys_to_fetch =
+            self.replication_fetcher
+                .add_keys(holder, incoming_keys, all_keys, is_fresh_replicate);
         if keys_to_fetch.is_empty() {
             debug!("no waiting keys to fetch from the network");
         } else {

diff --git a/ant-networking/src/lib.rs b/ant-networking/src/lib.rs
@@ -1104,6 +1104,10 @@ impl Network {
         self.send_local_swarm_cmd(LocalSwarmCmd::AddNetworkDensitySample { distance })
     }
 
+    pub fn notify_peer_scores(&self, peer_scores: Vec<(PeerId, bool)>) {
+        self.send_local_swarm_cmd(LocalSwarmCmd::NotifyPeerScores { peer_scores })
+    }
+
     /// Helper to send NetworkSwarmCmd
     fn send_network_swarm_cmd(&self, cmd: NetworkSwarmCmd) {
         send_network_swarm_cmd(self.network_swarm_cmd_sender().clone(), cmd);