Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Message in Toast if message prop is updated and updating toast position on screen orientation change #20

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

chitrangsinghvi
Copy link

@chitrangsinghvi chitrangsinghvi commented Jan 23, 2017

  • updating message in toast if message prop passed is updated.
  • animation on closing toast externally
  • support for screen orientation

@chitrangsinghvi chitrangsinghvi changed the title Updating Message in Toast if message prop is updated Updating Message in Toast if message prop is updated and updating toast position on screen orientation change Mar 24, 2017
@zhuyifan2013
Copy link

@chitrangsinghvi there is no need to be so complicated , just do this :
change the

style={[ styles.defaultStyle, position]}

to

style={[ styles.defaultStyle, position , {width: Dimensions.get('window').width}]}

and delete the width prop in styles.defaultStyle

@dudash
Copy link

dudash commented Nov 21, 2017

Any idea if/when this PR could merge? would be nice to have rotation support for long lived toasts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants