Example loading NPM module #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejhirsz
reviewed
May 27, 2023
maciejhirsz
reviewed
May 27, 2023
maciejhirsz
reviewed
May 27, 2023
| const wsProvider = new WsProvider('wss://rpc.polkadot.io'); | ||
| const api = await ApiPromise.create({ provider: wsProvider }); | ||
|
|
||
| return api.genesisHash.toHex(); |
There was a problem hiding this comment.
What's the type of genesisHash? You could potentially send raw binary from Uint8Array to Rust via &[u8] or Vec<u8> much more cheaply than via string (no Utf16 to Utf8 conversion necessary).
There was a problem hiding this comment.
it's of type Hash that extends H256, and H256 extends U8aFixed, and U8aFixed extends Raw, which is a wrapper
around Uint8Array that implements IU8a.
i tried to send Uint8Array as you mentioned in this commit d921638, but not sure how to convert the bytes to string.
i also tried https://crates.io/crates/serde-wasm-bindgen/0.4.2 serde_wasm_bindgen::from_value without any luck
maciejhirsz
reviewed
May 27, 2023
maciejhirsz
reviewed
May 27, 2023
error handling outside of the update Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Maciej Hirsz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
cd examples/npm_lib nvm use yarn yarn run esbuild RUST_LOG=info trunk serve --address=127.0.0.1 --opencargo test --target wasm32-unknown-unknownISSUES
yarn run esbuildPerhaps I need a#[allow(???)]https://doc.rust-lang.org/rustc/lints/listing/index.htmlwasm_bindgen_testit says "One other difference is that the tests must be in the root of the crate, or within a pub mod" and the implementation is in src/