Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit on wrong username/password. Keep trying with the other servers #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clopez
Copy link

@clopez clopez commented Jul 7, 2011

Don't exit on wrong username/password. Keep trying with the other servers.

Issue #25

@clopez
Copy link
Author

clopez commented Jul 7, 2011

Please merge also 0e557a1

The previous was broken and the former one is cleaner

@m0mchil
Copy link
Owner

m0mchil commented Jul 9, 2011

Thank you. Currently I can't decide if it is OK to not fail on bad credentials. If you can communicate with a pool but it rejects your password this perhaps should just be corrected or the server removed from the list?

@gominoa
Copy link
Contributor

gominoa commented Jul 9, 2011

I dont think failing to shell is good. Many miners may only be checked once a day. It should continue to do something useful. I think report the error and move on to next server is best. I could see someone starting the miner first then adding a new worker to pool. Or modifying credentials on pool before updating miners. Miner should always be doing something useful if possible.

@gominoa
Copy link
Contributor

gominoa commented Jul 9, 2011

How about bail out if only one server specified. Otherwise switch to backup.
Not sure what to do if both are NotAuth. Maybe add a counter and bail out if all servers fail?

@clopez
Copy link
Author

clopez commented Jul 9, 2011

I also think that failing to shell is always the worst option of all.

Most of miners are not human-checked more than once a day.

And it's a pity that your mine stopped working because of any error.

Actually as a workaround I wrap the execution of poclbm in a bash script that ensures that it will never end

while true; do
./poclbm [....]
sleep 60
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants