feat: Memory macro #10
Open
+536
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
reviewed
Nov 15, 2024
Comment on lines
+393
to
+394
| (relation (hash4 element wide wide wide wide)) ; (tag a b c d) | ||
| (relation (unhash4 element wide)) ; (tag digest) |
porcuquine
reviewed
Jan 15, 2025
|
|
||
| ;; TODO: Maybe it would be better for this to belong here? I've copied this over to evaluation.lisp for now. | ||
| #+nil | ||
| (defmacro defmem (prog-name superclasses config &body arg-specs) |
There was a problem hiding this comment.
Whatever we decide, let's have it live in only one place rather than duplicate and comment.
porcuquine
reviewed
Jan 16, 2025
Comment on lines
+72
to
+73
| (defun concat-sym (root suf) | ||
| (intern (format nil "~A~A" root suf))) |
porcuquine
reviewed
Jan 16, 2025
| ;; for example `allocation::ingress`, and this interferes with execution. | ||
| ;; There should definitely be a way to prevent this from happening in the first place, | ||
| ;; but I haven't been able to get anything to work. | ||
| ;; |
There was a problem hiding this comment.
I'm not totally following the issue, but it's not worth getting into the weeds on now, so let's just live with this comment.
porcuquine
requested changes
Jan 16, 2025
There was a problem hiding this comment.
This looks pretty good. I didn't thoroughly check the actual macro, but it seems reasonable and tests are passing. Please just add a test of the macroexpansion for the most complicated case (which I think is cons-mem?) — so we have a clear record of the intended behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
defmemmacro to automatically generate memory program. We have 3 types of memory:full: These are fully specified memories likecons,fun.digest-only: These are memories that only support digests, likebuiltin.immediate: These are for immediate types likenum.Depends on #9, please merge that first.